New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ajax requests that are using "Bufferless input streams" #806

Merged
merged 1 commit into from Jun 13, 2014

Conversation

Projects
None yet
3 participants
@ThomasZitzler

ThomasZitzler commented Jun 13, 2014

HttpRequest.Files throws an exception if the request is read using a
bufferless input stream (this is the case for some of my WCF services
with JSON endpoint). The excpetion screws up the whole switching to that
request. Catching the error will show all other data (e.g. SQL
statements) for that request without problem.

Look at the reference source to see the exception:
http://referencesource.microsoft.com/#System.Web/xsp/system/Web/HttpRequest.cs#d9b62e0b8c0ca2cd

After that fix it works for me properly.

Ajax requests that are using "Bufferless input streams" cannot be mon…
…itored

HttpRequest.Files throws an excpetion if the request is read using a
bufferless input stream (this is the case for some of my WCF services
with JSON endpoint). The excpetion screws up the whole switching to that
request. Catching the error will show all other data (e.g. SQL
statements) for that request without problem.
@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Jun 13, 2014

Member

I'm good with this fix. @nikmd23 @CGijbels Do either of you have any input?

Member

avanderhoorn commented Jun 13, 2014

I'm good with this fix. @nikmd23 @CGijbels Do either of you have any input?

@nikmd23

This comment has been minimized.

Show comment
Hide comment
@nikmd23

nikmd23 Jun 13, 2014

Member

This looks good to me as well.

Thanks @ThomasZitzler - I'm pulling this in now and it will go out with our next release.

Member

nikmd23 commented Jun 13, 2014

This looks good to me as well.

Thanks @ThomasZitzler - I'm pulling this in now and it will go out with our next release.

nikmd23 added a commit that referenced this pull request Jun 13, 2014

Merge pull request #806 from ThomasZitzler/master
Fix Ajax requests that are using "Bufferless input streams"

@nikmd23 nikmd23 merged commit 6dc925a into Glimpse:master Jun 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment