New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Build Mode detection of assemblies in Environment tab. Thanks ... #823

Merged
merged 2 commits into from Jul 17, 2014

Conversation

Projects
None yet
3 participants
@lohithgn
Contributor

lohithgn commented Jul 16, 2014

Implement Build Mode detection of assemblies and display it in Environment tab.
Add BuildMode property to EnvironmentAssemblyModel.
Private function IsAssemblyDebugBuild() to check for Debug attribute
Modified the Environment tab section display to include Build Mode column

Thanks to Steve Smith (@ardalis) for the tip and code to check if assembly is built in Debug

Implement Build Mode detection of assemblies in Environment tab. Than…
…ks to @ardalis for the tip and code to check if assembly is built in Debug
@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Jul 16, 2014

Member

Looks great to me. I'll let @nikmd23 take a look and bring this one in.

Member

avanderhoorn commented Jul 16, 2014

Looks great to me. I'll let @nikmd23 take a look and bring this one in.

@lohithgn

This comment has been minimized.

Show comment
Hide comment
@lohithgn

lohithgn Jul 16, 2014

Contributor

thanks anthony :)

Contributor

lohithgn commented Jul 16, 2014

thanks anthony :)

@nikmd23

This comment has been minimized.

Show comment
Hide comment
@nikmd23

nikmd23 Jul 16, 2014

We can iterate less (for a performance boost) by filtering the attributes collection with this overload of .GetCustomAttributes():

foreach (var attribute in assembly.GetCustomAttributes(typeof(DebuggableAttribute), false))

We can iterate less (for a performance boost) by filtering the attributes collection with this overload of .GetCustomAttributes():

foreach (var attribute in assembly.GetCustomAttributes(typeof(DebuggableAttribute), false))
@nikmd23

This comment has been minimized.

Show comment
Hide comment
@nikmd23

nikmd23 Jul 16, 2014

Member

@lohithgn also, we'll need you to sign our contributor license agreement.

You can email the completed form back to me. I use the same handle at gmail.com

Member

nikmd23 commented Jul 16, 2014

@lohithgn also, we'll need you to sign our contributor license agreement.

You can email the completed form back to me. I use the same handle at gmail.com

Update to IsAssemblyDebugBuild. Used overloaded method of GetCustomAt…
…tributes and getting only debuggableattribute
@lohithgn

This comment has been minimized.

Show comment
Hide comment
@lohithgn

lohithgn Jul 17, 2014

Contributor

Nik changed the code to use the overloaded method. signed and sent you the agreement.

Contributor

lohithgn commented Jul 17, 2014

Nik changed the code to use the overloaded method. signed and sent you the agreement.

@nikmd23

This comment has been minimized.

Show comment
Hide comment
@nikmd23

nikmd23 Jul 17, 2014

Member

Thanks @lohithgn! I've received the CLA and your changes look good.

I'm going to merge this in now and the feature will be available in our next release.

Also, thanks @ardalis for the idea!

Member

nikmd23 commented Jul 17, 2014

Thanks @lohithgn! I've received the CLA and your changes look good.

I'm going to merge this in now and the feature will be available in our next release.

Also, thanks @ardalis for the idea!

nikmd23 added a commit that referenced this pull request Jul 17, 2014

Merge pull request #823 from lohithgn/master
Implement Build Mode detection of assemblies in Environment tab. Thanks for the idea @ardalis and implementation by @lohithgn

@nikmd23 nikmd23 merged commit 93256e0 into Glimpse:master Jul 17, 2014

@avanderhoorn avanderhoorn added this to the vNext milestone Jul 17, 2014

@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Oct 29, 2014

Member

This update has gone out. Huge thanks!

Member

avanderhoorn commented Oct 29, 2014

This update has gone out. Huge thanks!

@lohithgn

This comment has been minimized.

Show comment
Hide comment
@lohithgn

lohithgn Nov 29, 2014

Contributor

woo hoo ... great to hear that this is out :)

Contributor

lohithgn commented Nov 29, 2014

woo hoo ... great to hear that this is out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment