Implement Build Mode detection of assemblies in Environment tab. Thanks ... #823

Merged
merged 2 commits into from Jul 17, 2014

Projects

None yet

3 participants

@lohithgn
Contributor

Implement Build Mode detection of assemblies and display it in Environment tab.
Add BuildMode property to EnvironmentAssemblyModel.
Private function IsAssemblyDebugBuild() to check for Debug attribute
Modified the Environment tab section display to include Build Mode column

Thanks to Steve Smith (@ardalis) for the tip and code to check if assembly is built in Debug

@lohithgn lohithgn Implement Build Mode detection of assemblies in Environment tab. Than…
…ks to @ardalis for the tip and code to check if assembly is built in Debug
b0867cd
@avanderhoorn
Member

Looks great to me. I'll let @nikmd23 take a look and bring this one in.

@lohithgn
Contributor

thanks anthony :)

@nikmd23

We can iterate less (for a performance boost) by filtering the attributes collection with this overload of .GetCustomAttributes():

foreach (var attribute in assembly.GetCustomAttributes(typeof(DebuggableAttribute), false))
@nikmd23
Member
nikmd23 commented Jul 16, 2014

@lohithgn also, we'll need you to sign our contributor license agreement.

You can email the completed form back to me. I use the same handle at gmail.com

@lohithgn
Contributor

Nik changed the code to use the overloaded method. signed and sent you the agreement.

@nikmd23
Member
nikmd23 commented Jul 17, 2014

Thanks @lohithgn! I've received the CLA and your changes look good.

I'm going to merge this in now and the feature will be available in our next release.

Also, thanks @ardalis for the idea!

@nikmd23 nikmd23 merged commit 93256e0 into Glimpse:master Jul 17, 2014
@avanderhoorn avanderhoorn added this to the vNext milestone Jul 17, 2014
@avanderhoorn
Member

This update has gone out. Huge thanks!

@lohithgn
Contributor

woo hoo ... great to hear that this is out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment