Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Validate Context.User.Identity before accessing it #872
I'm inheriting from IPrincipal interface (http://msdn.microsoft.com/en-us/library/system.security.principal.iprincipal(v=vs.110).aspx). To be honest, I was wondering if I could extract getting client identity behind the interface (e.g. IClientIdentityProvider, with method GetClientIdentity(HttpRequestBase) ), and inject it through Service Provider. This would allow me and other to easily override the way the client identity is provided. What do you think of this solution?
That should work, only thing is that we aren't really investing that much more into v1.x at the moment. With v2 it will have this style of extension out of the box, but obviously its missing form v1. That said, v2 is still a little bit away and if you are interested in doing the work for the extension, we would happy help out and bring it in for release. Let me know what you think. At the very least this PR can be merged in.