New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for a configurable buffer size #888

Merged
merged 4 commits into from Mar 11, 2015

Conversation

Projects
None yet
2 participants
@paynecrl97
Contributor

paynecrl97 commented Mar 11, 2015

Note: I started this work before I noticed PR #883; however, that PR has been inactive for 13 days so I thought I'd finish off the configurable request count aspect of it.

This adds support for a configurable buffer size by adding a BufferSize property to the configuration Section.

Example usage:

    <glimpse defaultRuntimePolicy="On" endpointBaseUri="~/Glimpse.axd" requestBufferSize="100">
        <!-- Additional Glimpse configuration nodes -->
    </glimpse>
@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Mar 11, 2015

Member

Looks great! Just wondering if you can sign the cla and send it through to anthony.vanderhoorn at the google mail place, that would be great! Once that happens we can bring it in.

Member

avanderhoorn commented Mar 11, 2015

Looks great! Just wondering if you can sign the cla and send it through to anthony.vanderhoorn at the google mail place, that would be great! Once that happens we can bring it in.

@paynecrl97

This comment has been minimized.

Show comment
Hide comment
@paynecrl97

paynecrl97 Mar 11, 2015

Contributor

Completed CLA sent. Let me know if you don't receive it (sometimes my personal emails fail to be delivered).

Contributor

paynecrl97 commented Mar 11, 2015

Completed CLA sent. Let me know if you don't receive it (sometimes my personal emails fail to be delivered).

avanderhoorn added a commit that referenced this pull request Mar 11, 2015

Merge pull request #888 from paynecrl97/configurable-buffer-size
Adds support for a configurable buffer size

@avanderhoorn avanderhoorn merged commit c0856a3 into Glimpse:master Mar 11, 2015

@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Mar 11, 2015

Member

Got it, great PR!

Member

avanderhoorn commented Mar 11, 2015

Got it, great PR!

@paynecrl97

This comment has been minimized.

Show comment
Hide comment
@paynecrl97

paynecrl97 Mar 11, 2015

Contributor

Thanks. I'll update the documentation too once this change makes it into the NuGet feed.

Contributor

paynecrl97 commented Mar 11, 2015

Thanks. I'll update the documentation too once this change makes it into the NuGet feed.

@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Mar 11, 2015

Member

Great! Good thinking.

Member

avanderhoorn commented Mar 11, 2015

Great! Good thinking.

@paynecrl97

This comment has been minimized.

Show comment
Hide comment
@paynecrl97

paynecrl97 Mar 11, 2015

Contributor

And finally- I don't know if you know this already but- although my PR triggered a private build (http://teamcity.codebetter.com/viewLog.html?buildId=185611&tab=buildResultsDiv&buildTypeId=bt428), the status of the build does not appear to have been reported to GitHub. In fact, it appears that the status of private builds have not been reported since August 2013.

Is this intentional? Or is it just an oversight?

Contributor

paynecrl97 commented Mar 11, 2015

And finally- I don't know if you know this already but- although my PR triggered a private build (http://teamcity.codebetter.com/viewLog.html?buildId=185611&tab=buildResultsDiv&buildTypeId=bt428), the status of the build does not appear to have been reported to GitHub. In fact, it appears that the status of private builds have not been reported since August 2013.

Is this intentional? Or is it just an oversight?

@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Mar 11, 2015

Member

Not sure where you mean? Can you send me a screen shot?

Member

avanderhoorn commented Mar 11, 2015

Not sure where you mean? Can you send me a screen shot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment