Adds support for a configurable buffer size #888

Merged
merged 4 commits into from Mar 11, 2015

Projects

None yet

2 participants

@paynecrl97
Contributor

Note: I started this work before I noticed PR #883; however, that PR has been inactive for 13 days so I thought I'd finish off the configurable request count aspect of it.

This adds support for a configurable buffer size by adding a BufferSize property to the configuration Section.

Example usage:

    <glimpse defaultRuntimePolicy="On" endpointBaseUri="~/Glimpse.axd" requestBufferSize="100">
        <!-- Additional Glimpse configuration nodes -->
    </glimpse>
@avanderhoorn
Member

Looks great! Just wondering if you can sign the cla and send it through to anthony.vanderhoorn at the google mail place, that would be great! Once that happens we can bring it in.

@paynecrl97
Contributor

Completed CLA sent. Let me know if you don't receive it (sometimes my personal emails fail to be delivered).

@avanderhoorn avanderhoorn merged commit c0856a3 into Glimpse:master Mar 11, 2015
@avanderhoorn
Member

Got it, great PR!

@avanderhoorn avanderhoorn added this to the vNext milestone Mar 11, 2015
@avanderhoorn avanderhoorn self-assigned this Mar 11, 2015
@paynecrl97
Contributor

Thanks. I'll update the documentation too once this change makes it into the NuGet feed.

@avanderhoorn
Member

Great! Good thinking.

@paynecrl97
Contributor

And finally- I don't know if you know this already but- although my PR triggered a private build (http://teamcity.codebetter.com/viewLog.html?buildId=185611&tab=buildResultsDiv&buildTypeId=bt428), the status of the build does not appear to have been reported to GitHub. In fact, it appears that the status of private builds have not been reported since August 2013.

Is this intentional? Or is it just an oversight?

@avanderhoorn
Member

Not sure where you mean? Can you send me a screen shot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment