New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets executed type as the `EventSubText` for `ISourceMessages` on the Timeline #889

Merged
merged 1 commit into from Apr 23, 2015

Conversation

Projects
None yet
2 participants
@paynecrl97
Contributor

paynecrl97 commented Mar 20, 2015

The problem:

image

It is impossible to tell from the Timeline view which filters relate to which timing event. This means that the user needs to switch to the Execution tab to get this data.

The solution:

We already have this data in the message (because it's rendered in the Execution tab), so we can assign this value to the EventSubText property of the TimelineMessage:

image

This also adds the full controller type name, as well as the type of Action Result:

image

@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Apr 23, 2015

Member

Happy for this to go in. Will make it in the next release. Nice addition.

Member

avanderhoorn commented Apr 23, 2015

Happy for this to go in. Will make it in the next release. Nice addition.

@avanderhoorn avanderhoorn added this to the vNext milestone Apr 23, 2015

@avanderhoorn avanderhoorn self-assigned this Apr 23, 2015

avanderhoorn added a commit that referenced this pull request Apr 23, 2015

Merge pull request #889 from paynecrl97/executed_type_as_subtext
Sets executed type as the `EventSubText` for `ISourceMessages` on the Timeline

@avanderhoorn avanderhoorn merged commit 025b660 into Glimpse:master Apr 23, 2015

1 check passed

default Finished TeamCity Build Glimpse :: Continuous Integration : Tests passed: 942, ignored: 10
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment