New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page adapters without qualifying assembly name #904

Merged
merged 2 commits into from May 27, 2015

Conversation

Projects
None yet
2 participants
@flcdrg
Contributor

flcdrg commented May 26, 2015

Resolve #903

  • Handle the case where a page adapter is configured without a qualifying assembly name, and attempt to resolve the type in the main web application assembly.
  • Avoid KeyNotFoundExceptions when processing view state

flcdrg added some commits May 26, 2015

Handle the case where a page adapter is configured without a qualifyi…
…ng assembly name, and attempt to resolve the type in the main web application assembly.

Avoid KeyNotFoundExceptions when processing view state

Trim trailing whitespace
@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn May 26, 2015

Member

Looks great! Just wondering if you can sign the cla and send it through to anthony.vanderhoorn at the google mail place, that would be great! Once that happens we can bring it in.

Member

avanderhoorn commented May 26, 2015

Looks great! Just wondering if you can sign the cla and send it through to anthony.vanderhoorn at the google mail place, that would be great! Once that happens we can bring it in.

@flcdrg

This comment has been minimized.

Show comment
Hide comment
@flcdrg

flcdrg May 27, 2015

Contributor

Emailed CLA in as requested

Contributor

flcdrg commented May 27, 2015

Emailed CLA in as requested

@avanderhoorn avanderhoorn added this to the vNext milestone May 27, 2015

@avanderhoorn avanderhoorn self-assigned this May 27, 2015

avanderhoorn added a commit that referenced this pull request May 27, 2015

Merge pull request #904 from flcdrg/PageAdapterNRE
Page adapters without qualifying assembly name

@avanderhoorn avanderhoorn merged commit f8aeb14 into Glimpse:master May 27, 2015

1 check passed

default Finished TeamCity Build Glimpse :: Continuous Integration : Tests passed: 942, ignored: 10
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment