New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display full time zone offset (not just hours) #909

Merged
merged 1 commit into from Jun 12, 2015

Conversation

Projects
None yet
2 participants
@flcdrg
Contributor

flcdrg commented Jun 5, 2015

Use DateTimeOffset and obtain full time zone offset (include minutes component instead of assuming time zones are always on the hour)

Label 'UTC' instead of 'GMT'

Resolves #908

Use DateTimeOffset and obtain full time zone offset (include minutes …
…component instead of assuming time zones are always on the hour)

Label 'UTC' instead of 'GMT'
@avanderhoorn

This comment has been minimized.

Show comment
Hide comment
@avanderhoorn

avanderhoorn Jun 5, 2015

Member

Looks great! Only minor thing is the change to the js file needs to be
mimicked in the Glimpse.Client repo, otherwise they get out of sync.
Usually a change is made to the glimpse client, it is built and then the
change is brought across. https://github.com/Glimpse/Glimpse.Client

On Thursday, June 4, 2015, David Gardiner notifications@github.com wrote:

Use DateTimeOffset and obtain full time zone offset (include minutes
component instead of assuming time zones are always on the hour)

Label 'UTC' instead of 'GMT'

Resolves #908 #908

You can view, comment on, or merge this pull request online at:

#909
Commit Summary

  • Use DateTimeOffset and obtain full time zone offset (include minutes
    component instead of assuming time zones are always on the hour)

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#909.

Member

avanderhoorn commented Jun 5, 2015

Looks great! Only minor thing is the change to the js file needs to be
mimicked in the Glimpse.Client repo, otherwise they get out of sync.
Usually a change is made to the glimpse client, it is built and then the
change is brought across. https://github.com/Glimpse/Glimpse.Client

On Thursday, June 4, 2015, David Gardiner notifications@github.com wrote:

Use DateTimeOffset and obtain full time zone offset (include minutes
component instead of assuming time zones are always on the hour)

Label 'UTC' instead of 'GMT'

Resolves #908 #908

You can view, comment on, or merge this pull request online at:

#909
Commit Summary

  • Use DateTimeOffset and obtain full time zone offset (include minutes
    component instead of assuming time zones are always on the hour)

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#909.

@flcdrg

This comment has been minimized.

Show comment
Hide comment
@flcdrg

flcdrg Jun 9, 2015

Contributor

I've created a separate PR for the Glimpse.Client repo with just the JavaScript change

Contributor

flcdrg commented Jun 9, 2015

I've created a separate PR for the Glimpse.Client repo with just the JavaScript change

@avanderhoorn avanderhoorn added this to the vNext milestone Jun 12, 2015

@avanderhoorn avanderhoorn self-assigned this Jun 12, 2015

avanderhoorn added a commit that referenced this pull request Jun 12, 2015

Merge pull request #909 from flcdrg/Timezones
Display full time zone offset (not just hours)

@avanderhoorn avanderhoorn merged commit 0f01bb3 into Glimpse:master Jun 12, 2015

1 check passed

default Finished TeamCity Build Glimpse :: Continuous Integration : Tests passed: 942, ignored: 10
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment