Fix is_resource returning false in php8 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this repo still maintained? |
Likho
approved these changes
Apr 26, 2021
Likho
approved these changes
Apr 26, 2021
go0sedev
approved these changes
Jul 16, 2021
|
Is there anything in particular blocking this from being merged? |
|
Hi @willbrowningme we're having a look at it. Will update you as it's merged in. |
Eddie-Globee
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP8
is_resource(curl_init())returns false. This causes$this->clientto be overwritten each time$this->getClient()is called e.g in thesendmethod ofGloBeeCurlConnectorwhich results in an error since no URL is set whencurl_exec($this->getClient())is called.This pull request adds
is_object()to prevent$this->clientbeing overwritten in PHP8.Mentioned in this repo too - aliyun/aliyun-oss-php-sdk#153
Tested and working on my server.