Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP Admin dashboard administration #14

Open
polevaultweb opened this issue Sep 25, 2015 · 15 comments

Comments

@polevaultweb
Copy link
Contributor

commented Sep 25, 2015

Add GlotPress menu. Ability to administer projects, translation sets etc.

@polevaultweb polevaultweb self-assigned this Sep 25, 2015

@polevaultweb polevaultweb added this to the Convert to Plugin milestone Sep 25, 2015

@polevaultweb polevaultweb added the has PR label Sep 25, 2015

@ocean90

This comment has been minimized.

Copy link
Member

commented Sep 25, 2015

Maybe we should dicuss first which options would be needed and if it should happen in admin or on front end.

@polevaultweb

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2015

Personally I think the majority of the admin related stuff makes more sense in the wp admin. The wip PR will replicate admin, without removing from the frontend. Currently looking at projects admin.

@bradt

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2015

This is waaay too lofty of an undertaking for this milestone.

@polevaultweb

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2015

Ha!

@bradt

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2015

Also, what did you have in mind exactly for "Ability to administer projects, translation sets etc." ? Isn't all that already available from the GlotPress UI? Wouldn't it just be duplication?

@polevaultweb

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2015

True, but if you were building the plugin from scratch as a WP plugin, wouldn't you utilise the WP admin, tables, UI and functionality to manage adding, editing projects etc?

@polevaultweb

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2015

It's only available in the frontend because GP has no backend

@ocean90

This comment has been minimized.

Copy link
Member

commented Sep 25, 2015

Projects have only 6 settings. Once they're set you'll probably never change them again.

Even as a plugin, we should try to use WordPress just as a library. I think it should be possible that you can have people who can access GlotPress without knowing that WordPress is actually running behind it.

utilise the WP admin, tables, UI and functionality to manage adding, editing projects etc

If you can make it work for ~40k projects which can be three levels deep, sure. But I bet that's not that easy. :)

@polevaultweb

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2015

Good points. Will park it for now

@toolstack

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2015

The one setting we do need to add is the ability to change the slug used for GlotPress's URL. At the moment it's set to "/glotpress", but a site may want something different.

@ocean90

This comment has been minimized.

Copy link
Member

commented Sep 25, 2015

@toolstack Such a setting can be added to the existing Permalinks screen. Or make it filterable. :)

@toolstack

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2015

@ocean90 could be, but that hiding it a bit, the settings menu doesn't have to a top level menu, it could be in the settings menu. I would think many installs will want to change the link, before it was easy as you just changed the directory you installed in to, but as a plugin that's more difficult.

@bradt

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2015

@toolstack It is already configurable via the GP_URL_BASE constant.

@toolstack

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2015

There's configurable and then there's easily configurable :)

The plugin gives us an easy interface to let the admin configure this kind of setting without messing with the config file.

@A5hleyRich

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2015

It seems overkill adding a settings screen just to define the base URL. Often it's a one time change so the menu item would become redundant.

@bradt bradt modified the milestones: 1.0, Future Oct 1, 2015

@polevaultweb polevaultweb removed their assignment Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.