Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning and disable the plugin if permalinks are not set. #218

Closed
toolstack opened this issue Jan 19, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@toolstack
Copy link
Contributor

commented Jan 19, 2016

GlotPress requires permalinks to be set, so just like unsupported versions of WordPress, we should add an admin notice and disable the plugin if they don't exist.

@ocean90

This comment has been minimized.

Copy link
Member

commented Jan 20, 2016

I'm not sure if we really have to disable the plugin. A warning should be fine. We could also try to enable them via wp_install_maybe_enable_pretty_permalinks(), see https://github.com/WordPress/WordPress/blob/06a3f799e744578ccae2741534dfc5949606b65b/wp-admin/includes/upgrade.php#L279.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.