Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions for translations have no gp_ prefix #232

Closed
ocean90 opened this issue Jan 22, 2016 · 3 comments
Closed

Actions for translations have no gp_ prefix #232

ocean90 opened this issue Jan 22, 2016 · 3 comments

Comments

@ocean90
Copy link
Member

@ocean90 ocean90 commented Jan 22, 2016

The action translation_created in https://github.com/GlotPress/GlotPress-WP/blob/1.0.1/gp-includes/things/translation.php#L330 and translation_saved in https://github.com/GlotPress/GlotPress-WP/blob/1.0.1/gp-includes/things/translation.php#L335 don't have a gp_ prefix like all the other actions.

For a minor/patch release we should add the same action with the gp_ prefix and in the next major release we can remove the non-prefixed action. (http://semver.org/spec/v2.0.0.html)
Thoughts?

@ocean90 ocean90 added this to the 1.1 milestone Jan 22, 2016
@toolstack
Copy link
Contributor

@toolstack toolstack commented Jan 22, 2016

I'd consider it a bug, the intent was to prepend all actions so it can be patched and released in the 1.0.2 or 1.1, whichever comes out first.

@ocean90
Copy link
Member Author

@ocean90 ocean90 commented Jan 22, 2016

Yes, it's a bug, but adding a prefix is a backwards-incompatible change. That's why I've proposed the interim step with adding both variants.

@toolstack
Copy link
Contributor

@toolstack toolstack commented Jan 22, 2016

Making a backwards-incompatible change due to a bug fix is alright as far as I'm concerned, bugs by definition are backwards-incompatible ;)

We could just leave it as is in 1.0.2 (if we make one) and leave it to 1.1 to add the prefix.

I'd almost not consider this a backwards compatibility item as the API remains the same (do_action/add_action) it's only which hooks are available to use, which is almost data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants