Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child projects are inaccessible if permalinks have trailing slash #265

Closed
toolstack opened this issue Feb 12, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@toolstack
Copy link
Contributor

commented Feb 12, 2016

If the permalink structure has a trailing slash in it and you create a child project, that project is inaccessible because $project->update_path() does not trim the trailing slash, but the $project->by_path() does.

@ocean90

This comment has been minimized.

Copy link
Member

commented Feb 12, 2016

Noticed the same a few days ago too, thanks for creating the issue. 👍

It's important that we store the paths without trailing slashes so we're compatible with a later switch to a non-trailing slash structure.
Looking at GP_Project->regenerate_paths() and it seems to have the same issue.

@toolstack

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2016

Updated the PR with the regenerate_paths() fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.