New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject with feedback #324

Open
ocean90 opened this Issue Mar 11, 2016 · 8 comments

Comments

Projects
None yet
5 participants
@ocean90
Member

ocean90 commented Mar 11, 2016

From https://glotpress.trac.wordpress.org/ticket/335

As an validator I want to decline a validation with a message so the translator know who declined it and why.
This way I don't need to fix the translation and get's the original translator the credit it deserves.

@ocean90 ocean90 added the feature label Mar 11, 2016

@ocean90 ocean90 added this to the Future milestone Mar 11, 2016

@ocean90

This comment has been minimized.

Show comment
Hide comment
@ocean90

ocean90 Mar 11, 2016

Member

A possible workflow from #323: #323 (comment)

Member

ocean90 commented Mar 11, 2016

A possible workflow from #323: #323 (comment)

@Presskopp

This comment has been minimized.

Show comment
Hide comment
@Presskopp

Presskopp Apr 25, 2018

We discussed in our last german #polyglots meeting how the workflow in Glotpress could be improved for PTEs when strings need to be rejected. In result we would explicitly support the idea of 'rejecting with feedback'. There's a mockup on #323 (comment). We'd like to suggest the following changes, see image:

reject

We would appreciate checkboxes (including multiple choices) above the 'reject' button with standard reasons as a feedback for the contributor. Also with an extra comment field to give additional explanation, or if another reason is given.
This would be an enormous help for the process of involving people to the translation process.

Presskopp commented Apr 25, 2018

We discussed in our last german #polyglots meeting how the workflow in Glotpress could be improved for PTEs when strings need to be rejected. In result we would explicitly support the idea of 'rejecting with feedback'. There's a mockup on #323 (comment). We'd like to suggest the following changes, see image:

reject

We would appreciate checkboxes (including multiple choices) above the 'reject' button with standard reasons as a feedback for the contributor. Also with an extra comment field to give additional explanation, or if another reason is given.
This would be an enormous help for the process of involving people to the translation process.

@Mte90

This comment has been minimized.

Show comment
Hide comment
@Mte90

Mte90 Apr 25, 2018

Collaborator

It is not a bad idea of a preset for feedback but maybe we can do it after the release of the first implementation?

Collaborator

Mte90 commented Apr 25, 2018

It is not a bad idea of a preset for feedback but maybe we can do it after the release of the first implementation?

@La-Geek

This comment has been minimized.

Show comment
Hide comment
@La-Geek

La-Geek Apr 26, 2018

This is a must have feature (with the greatest respect to all your development work, but I would call it a bug, not to have it, that is no claim).

What we (users with global permissions to approve) have at the moment is:

  • see an error and reject this string without comment.
  • The translator sees a rejected string if he notices it at all.
  • Hopefully he'll recognize the mistake, if he doesn't, he'll make the same mistake again.
  • And the user with related permissions rejects again (with a little bad luck, we're going around in circles).
  • As an option, the user with related permissions tries to contact the translator, but how?
  • The only way to contact him is with his nickname.
  • With a bit of luck you can reach him by posting in any thread via @Nickname.
  • Or you're lucky and he's registered in Slack.
  • Or you find more informations in his profile, like website.

Can you feel how time-consuming this process is? We have thousands of waiting strings, and in German Polyglots Team less than 10 active PTEs/GTEs with global permissions to approve strings.

In addition: there is no reference in GlotPress to the locale translation team, the rules and where you can find both. Translators often get to Glotpress via the plugin or theme page. Some translators don't even know such a thing exists (but this is another ticket) and is just to show that translators may not even know the local team and the rules to ask their questions.

@Mte90:
I don't know exactly, how the first implementation will look. But on the roadmap you'll see: Glotpress has not reached 3.0 final version and the feature "reject with comment" is planned for 3.2 stable.

All we ask is to reconsider priorities. We don't need a nice GlotPress, we need one that makes our work easier. We do not know the internal processes and also trust the developers' judgment. But it may not be known how urgently we need this feature.

Thanks to @Presskopp for his detailed description.

La-Geek commented Apr 26, 2018

This is a must have feature (with the greatest respect to all your development work, but I would call it a bug, not to have it, that is no claim).

What we (users with global permissions to approve) have at the moment is:

  • see an error and reject this string without comment.
  • The translator sees a rejected string if he notices it at all.
  • Hopefully he'll recognize the mistake, if he doesn't, he'll make the same mistake again.
  • And the user with related permissions rejects again (with a little bad luck, we're going around in circles).
  • As an option, the user with related permissions tries to contact the translator, but how?
  • The only way to contact him is with his nickname.
  • With a bit of luck you can reach him by posting in any thread via @Nickname.
  • Or you're lucky and he's registered in Slack.
  • Or you find more informations in his profile, like website.

Can you feel how time-consuming this process is? We have thousands of waiting strings, and in German Polyglots Team less than 10 active PTEs/GTEs with global permissions to approve strings.

In addition: there is no reference in GlotPress to the locale translation team, the rules and where you can find both. Translators often get to Glotpress via the plugin or theme page. Some translators don't even know such a thing exists (but this is another ticket) and is just to show that translators may not even know the local team and the rules to ask their questions.

@Mte90:
I don't know exactly, how the first implementation will look. But on the roadmap you'll see: Glotpress has not reached 3.0 final version and the feature "reject with comment" is planned for 3.2 stable.

All we ask is to reconsider priorities. We don't need a nice GlotPress, we need one that makes our work easier. We do not know the internal processes and also trust the developers' judgment. But it may not be known how urgently we need this feature.

Thanks to @Presskopp for his detailed description.

@Mte90

This comment has been minimized.

Show comment
Hide comment
@Mte90

Mte90 Apr 26, 2018

Collaborator

As we written on slack, GTE/PTE is not glotpress but WordPress Meta that is another team and has their channels for suggest that.

The first implementation is #804 with few screenshots that I made during the development.
We are getting slow for 3.0 that until the release is blocking on develop new feature (this pr has a lot of conflicts that i want to fix only when the new release is available).

Collaborator

Mte90 commented Apr 26, 2018

As we written on slack, GTE/PTE is not glotpress but WordPress Meta that is another team and has their channels for suggest that.

The first implementation is #804 with few screenshots that I made during the development.
We are getting slow for 3.0 that until the release is blocking on develop new feature (this pr has a lot of conflicts that i want to fix only when the new release is available).

@La-Geek

This comment has been minimized.

Show comment
Hide comment
@La-Geek

La-Geek Apr 26, 2018

We are asking for a feature in GlotPress, nothing more. And this seems to be the right place for this. Sorry, I don't understand, I will ask you in Slack what you mean.

Thank you for clarification at Slack. We are looking forward to the further steps in the development :)

La-Geek commented Apr 26, 2018

We are asking for a feature in GlotPress, nothing more. And this seems to be the right place for this. Sorry, I don't understand, I will ask you in Slack what you mean.

Thank you for clarification at Slack. We are looking forward to the further steps in the development :)

@Presskopp

This comment has been minimized.

Show comment
Hide comment
@Presskopp

Presskopp Apr 26, 2018

didn't notice #804 - great to see there's already a history of progress on that

Presskopp commented Apr 26, 2018

didn't notice #804 - great to see there's already a history of progress on that

@davidperezgar

This comment has been minimized.

Show comment
Hide comment
@davidperezgar

davidperezgar Aug 16, 2018

Yes! It's a must feature!

davidperezgar commented Aug 16, 2018

Yes! It's a must feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment