New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Notice: Undefined property: Translation_Entry::$user_login in /gp-templates/translation-row.php #386

Closed
ocean90 opened this Issue Apr 6, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@ocean90
Copy link
Member

ocean90 commented Apr 6, 2016

Notice: Undefined property: Translation_Entry::$user_login in /gp-templates/translation-row.php on line 12

Happens if a translation has a user_id but the user was deleted in the meantime. See https://github.com/GlotPress/GlotPress-WP/blob/2.0.0/gp-includes/things/translation.php#L254-L256

@ocean90 ocean90 added the bug label Apr 6, 2016

@ocean90 ocean90 added this to the 2.1 milestone Apr 6, 2016

ocean90 added a commit that referenced this issue Apr 6, 2016

Translations: Initialize `user_login`, `user_display_name`, and `user…
…_nicename` properties.

Avoids an undefined property PHP notice if the user doesn't exist anymore.

Fixes #386.

@ocean90 ocean90 added the has PR label Apr 6, 2016

@ocean90 ocean90 closed this in #387 Apr 13, 2016

toolstack added a commit that referenced this issue Apr 25, 2016

Translations: Initialize `user_login`, `user_display_name`, and `user…
…_nicename` properties.

Avoids an undefined property PHP notice if the user doesn't exist anymore.

Fixes #386.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment