GP_Translation::translations() returns one extra entry #516

Closed
SergeyBiryukov opened this Issue Jul 20, 2016 · 0 comments

Projects

None yet

2 participants

@SergeyBiryukov
Collaborator

In GP_Translations, there are 6 fields for plural forms (translation_0 to translation_5). and $number_of_plural_translations equals 6.

The translations() method, however, uses a loop on a range of 0 to 6, which results in 7 loop iterations and 7 entries in the resulting array.

There's a similar extra iteration in a couple of other methods too, which seems like an oversight as well.

@toolstack toolstack added the bug label Jul 21, 2016
@toolstack toolstack added this to the 2.2 milestone Jul 21, 2016
@toolstack toolstack self-assigned this Jul 21, 2016
@toolstack toolstack added the has PR label Jul 21, 2016
@ocean90 ocean90 closed this in #518 Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment