Cancel link on projects/-new can have an empty href attribute #547

Closed
ocean90 opened this Issue Sep 15, 2016 · 1 comment

Projects

None yet

2 participants

@ocean90
Member
ocean90 commented Sep 15, 2016
<p>
        <input type="submit" name="submit" value="Create" id="submit" />
        <span class="or-cancel">or <a href="">Cancel</a></span>
</p>

Notice the empty href attribute. This happens if GP_URL_BASE is '/' and the current permalink structure has no trailing slash.

@ocean90 ocean90 added the bug label Sep 15, 2016
@ocean90 ocean90 added this to the 2.3 milestone Sep 15, 2016
@toolstack
Contributor

This is because gp_url() is the wrong function to use here, it only returns a relative portion of the url and what we really want is the GP root URL in this case.

We should use gp_url_public_root() instead.

@toolstack toolstack self-assigned this Sep 17, 2016
@toolstack toolstack added the has PR label Sep 17, 2016
@ocean90 ocean90 closed this in #548 Sep 19, 2016
@ocean90 ocean90 modified the milestone: 2.2, 2.3 Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment