New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcut for copying original string #554

Closed
GaryJones opened this Issue Sep 21, 2016 · 11 comments

Comments

Projects
None yet
9 participants
@GaryJones

GaryJones commented Sep 21, 2016

Originally https://glotpress.trac.wordpress.org/ticket/98.

The en_* locales would really benefit from having a keyboard shortcut that copied the original string(s) and put focus into the input field for potential editing, and allowing the existing Shift-Enter keyboard shortcut to submit the string.

For en_GB, en_AU, en_SA, en_CA, and en_NZ, this would make translations in the ballpark of twice as quick. Those inputting strings for a locale where the original string is in a variation of that locale would also benefit (i.e. Informal German into Formal German etc. or some combinations of Spanish or Portuguese.)

The Trac ticket has a patch as a starting point.

@yayannabelle

This comment has been minimized.

yayannabelle commented Sep 21, 2016

Not sure if entirely relevant, but it'd definitely make things more accessible, allowing a user to focus their hands solely on the keyboard, instead of going back and forth between mouse/keyboard, allowing for better efficiency, less energy used, and such.

Aka: Yes to all of the above! Please, great GlotPress gods, please bestow this feature upon us!

@ocean90 ocean90 added the enhancement label Sep 21, 2016

@ocean90 ocean90 added this to the Future milestone Sep 21, 2016

@toolstack toolstack added the has PR label Sep 21, 2016

@ocean90

This comment has been minimized.

Member

ocean90 commented Sep 26, 2016

Finding shortcuts which work for everyone is hard. The PR uses some which are already used by the OS.

What do you think about using something like https://craig.is/killing/mice which provides a simple API and also a plugin to record shortcuts so a user could define their own shortcuts for specific actions?

@toolstack

This comment has been minimized.

Contributor

toolstack commented Sep 26, 2016

The trade off is standardization vs customization, in this case I think standardization wins out, but that's my opionion.

Something like Mousetrap could simplify our keyboard handling but I'm not sure it's worth the extra library. It could be worth a look though during the redesign for a more fulsome review of our keyboard interactions.

@ocean90 ocean90 modified the milestones: 2.3, Future Sep 27, 2016

@ocean90

This comment has been minimized.

Member

ocean90 commented Sep 28, 2016

I'm interested what other users think about this:

  1. Are you using keyboard shortcuts?
  2. What actions should have a shortcut?
  3. Which keys should be used for shortcut? Should they be customizable?
  4. Are you using any other services which provides keyboard shortcuts which you can recommend?
@ujdhesa

This comment has been minimized.

ujdhesa commented Sep 28, 2016

  1. Yes.
  2. Copy, Paste, Save, Save As and similar.
  3. The usual ones, used from OS interfaces. Customizable preferably.
  4. Yes. Transifex, Poonton.
@glueckpress

This comment has been minimized.

glueckpress commented Sep 28, 2016

  1. Yes.
  2. Copy, paste, find (search), tabs to skip through the UI.
  3. A shortcut to open/focus the text filter field would be awesome. Not sure about which keys should be used, maybe alt+ctrl+F? Customizing would be nice to have, but not required for initial feature imo.
  4. The visual editor in WordPress has pretty useful shortcuts for headings and the like. Trello has some neat ones, and Slack.
@GaryJones

This comment has been minimized.

GaryJones commented Sep 28, 2016

  1. Are you using keyboard shortcuts? Yes
  2. What actions should have a shortcut? Submit and Copy From Original to start with. Approve and Reject would also be useful.
  3. Which keys should be used for shortcut? Should they be customizable? If text fields are not selected, then single keys on their own, with no modifiers, may work well.
  4. Are you using any other services which provides keyboard shortcuts which you can recommend? GitHub :-) Hit Shift-? and the Show All to see all the shortcuts GitHub supports.
@Mte90

This comment has been minimized.

Collaborator

Mte90 commented Sep 28, 2016

GlotDict have different hotkeys maybe can be helpful :-) https://github.com/Mte90/GlotDict#hotkeys

@yayannabelle

This comment has been minimized.

yayannabelle commented Sep 28, 2016

  1. Are you using keyboard shortcuts?

Yep, shift + enter for saving translations.

  1. What actions should have a shortcut?

Copying from Original, for sure! Approving/rejecting would be useful, but I'd prioritise the copying function over those.

  1. Which keys should be used for shortcut? Should they be customisable?

As I don't use ctrl + arrow keys for their intended purposes (Mac user, hi), I'd be up for using some combination of them - I'd say ctrl + down arrow, as it'd feel like you're pulling the original translation down, making it easy to remember. (I can then re-map the shortcut for switching application windows in my settings, no worries.) That being said, having the shortcut be customisable would be very handy!!

  1. Are you using any other services which provides keyboard shortcuts which you can recommend?

When using it previously, Notational Velocity had awesome shortcuts. GitHub as well! Atom's also pretty neat shortcut-wise.

@ntwb

This comment has been minimized.

ntwb commented Sep 29, 2016

  1. Yes
  2. Copy original
  3. CTRL-SHIFT-B
  4. GlotDict https://github.com/Mte90/GlotDict#hotkeys

This is from someone coming from the viewpoint of an English variant, copying from the original string is 95%+ of the actions performed for English variants

@ePascalC

This comment has been minimized.

ePascalC commented Sep 30, 2016

Please get inspiration from GlotDict: https://github.com/Mte90/GlotDict#hotkeys
A way to easily define a set of actions as a user would be great of course! Like the CTRL+SHIFT+F in GlotDict that would check for a space in front of ':' and replace it with a non-breaking space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment