Don't create duplicate translations with status waiting+warning during imports #579

Closed
ocean90 opened this Issue Oct 17, 2016 · 0 comments

Projects

None yet

1 participant

@ocean90
Member
ocean90 commented Oct 17, 2016

I noticed this on translate.w.org. We sync plugin translations from a dev to a stable project. Example flow:

This happens since #402. When a translation has warnings, GP sets the status to waiting but it doesn't check whether the same translation already exists with the same status.

cc: @akirk

@ocean90 ocean90 added the bug label Oct 17, 2016
@ocean90 ocean90 added this to the 2.3 milestone Oct 17, 2016
@akirk akirk added a commit to akirk/GlotPress that referenced this issue Oct 18, 2016
@akirk akirk Fixes #579: Prevent importing translations with warning twice 9fa852b
@akirk akirk added a commit to akirk/GlotPress that referenced this issue Oct 18, 2016
@akirk akirk Fixes #579: Prevent importing translations with warning twice ed072db
@ocean90 ocean90 added the has PR label Oct 18, 2016
@ocean90 ocean90 closed this in #581 Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment