New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate GlotPress standalone users and usermeta tables #6

Closed
bradt opened this Issue Sep 24, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@bradt
Contributor

bradt commented Sep 24, 2015

As per #5, the plan is for the GlotPress plugin to no longer have a separate users and usermeta, but to use WordPress' tables as well as all the WordPress authentication awesomeness. If someone really doesn't want to mix their GlotPress users with the other users of their site, they can setup an independent WordPress install just for GlotPress.

GlotPress standalone can be setup to share a WordPress install's users and usermeta tables by defining the CUSTOM_USER_TABLE and CUSTOM_USER_META_TABLE constants. If that's the case for your GlotPress standalone install, then no migration is necessary.

If your standalone GlotPress install doesn't share the users and usermeta tables with a WordPress install, you will need to migrate the GlotPress users and usermeta table to the WordPress users and usermeta tables.

I propose that upon plugin activation, we detect if the GlotPress user and usermeta tables already exist and provide a dashboard-wide notice something to the effect...

Import GlotPress Users? — We've detected users from a GlotPress standalone install. The GlotPress plugin no longer uses those tables. Would you like to import the users and their data into WordPress?
[ Yes ] [ No ]

If they choose "No", we should permanently dismiss the notice. If they choose "Yes", we should take them to Tools > Import where they can choose to install a "GlotPress Users" plugin to carry out the import.

@bradt bradt modified the milestone: Convert to Plugin Sep 24, 2015

@gilbitron

This comment has been minimized.

Member

gilbitron commented Sep 24, 2015

👍

@toolstack

This comment has been minimized.

Contributor

toolstack commented Sep 25, 2015

I don't know if this is even necessary, GP has never had a 1.0 release so anyone who's installed it can expect breaking changes and this could fall in to that category. Especially since most people who would be interested in it probably already run GP using the WP users table :)

@JRGould

This comment has been minimized.

Contributor

JRGould commented Sep 30, 2015

This seems like functionality that should go into a plugin as it will probably be used/useful for only a short time after the GlotPress plugin is released. After that, it will mostly just be cruft that needs to be maintained indefinitely or have a committee vote to remove it.

@bradt bradt modified the milestones: Future, 1.0 Oct 1, 2015

@bradt

This comment has been minimized.

Contributor

bradt commented Oct 1, 2015

@toolstack toolstack added the wontfix label Jun 24, 2017

@toolstack toolstack removed this from the Future milestone Jun 24, 2017

@toolstack

This comment has been minimized.

Contributor

toolstack commented Jun 24, 2017

Closing as won't fix as we're well beyond this now :)

@toolstack toolstack closed this Jun 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment