Export code does not quote filenames when downloading #633

Closed
toolstack opened this Issue Jan 10, 2017 · 0 comments

Projects

None yet

1 participant

@toolstack
Contributor

If a custom gp_export_translations_filename filter returns a filename with a space in it the browser will truncate the filename at the first space.

This is because headers_for_download in the base route class does not enclose the filename in double quotes see https://github.com/GlotPress/GlotPress-WP/blob/develop/gp-includes/route.php#L287

@toolstack toolstack self-assigned this Jan 10, 2017
@toolstack toolstack added the bug label Jan 10, 2017
@toolstack toolstack added this to the 2.3 milestone Jan 10, 2017
@toolstack toolstack added the has PR label Jan 10, 2017
@ocean90 ocean90 closed this in #634 Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment