New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export code does not quote filenames when downloading #633

Closed
toolstack opened this Issue Jan 10, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@toolstack
Contributor

toolstack commented Jan 10, 2017

If a custom gp_export_translations_filename filter returns a filename with a space in it the browser will truncate the filename at the first space.

This is because headers_for_download in the base route class does not enclose the filename in double quotes see https://github.com/GlotPress/GlotPress-WP/blob/develop/gp-includes/route.php#L287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment