New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misspelled action and incorrect comment in GP_Original::closest_original() #729

Closed
SergeyBiryukov opened this Issue Jun 3, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@SergeyBiryukov
Member

SergeyBiryukov commented Jun 3, 2017

Found two issues in GP_Original::closest_original():

  • The gp_post_string_similiary_test action is misspelled, I think it should be gp_post_string_similarity_test.
  • The comment says: "Fires before determining string similarity", but it fires after determining the similarity, not before.
@ocean90

This comment has been minimized.

Show comment
Hide comment
@ocean90

ocean90 Jun 7, 2017

Member

Introduced in https://glotpress.trac.wordpress.org/changeset/1032.

@yoavf Does wp.com use the action?

Member

ocean90 commented Jun 7, 2017

Introduced in https://glotpress.trac.wordpress.org/changeset/1032.

@yoavf Does wp.com use the action?

@toolstack toolstack added the bug label Jun 23, 2017

@toolstack toolstack added this to the 3.0 milestone Jun 23, 2017

@toolstack

This comment has been minimized.

Show comment
Hide comment
@toolstack

toolstack Jun 23, 2017

Contributor

I added the 3.0 milestone to this as it is an API breaking change.

Otherwise it looks good to me.

Contributor

toolstack commented Jun 23, 2017

I added the 3.0 milestone to this as it is an API breaking change.

Otherwise it looks good to me.

@yoavf

This comment has been minimized.

Show comment
Hide comment
@yoavf

yoavf Jun 25, 2017

Member

@yoavf Does wp.com use the action?

I don't think we are. Thanks for catching this @SergeyBiryukov

Member

yoavf commented Jun 25, 2017

@yoavf Does wp.com use the action?

I don't think we are. Thanks for catching this @SergeyBiryukov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment