New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string counts to the filter links #733

Closed
garrett-eclipse opened this Issue Jun 14, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@garrett-eclipse

garrett-eclipse commented Jun 14, 2017

Hello,

Wanted to suggest adding string counts to the filter links;
screen shot 2017-06-14 at 9 27 53 am

Thanks

@toolstack

This comment has been minimized.

Show comment
Hide comment
@toolstack

toolstack Jun 14, 2017

Contributor

It's possible to do but it would have a performance impact as we only load the strings required for a given page from SQL and not the entire translation set.

Getting the totals would require several more SQL statements.

Contributor

toolstack commented Jun 14, 2017

It's possible to do but it would have a performance impact as we only load the strings required for a given page from SQL and not the entire translation set.

Getting the totals would require several more SQL statements.

@garrett-eclipse

This comment has been minimized.

Show comment
Hide comment
@garrett-eclipse

garrett-eclipse Jun 14, 2017

I can see the performance issue there forsure, if it's about page load over server load they could be introduced through ajax if there was an endpoint to call for counts.
And maybe if not worthy of GlotPress itself the GlotDict extension could introduce for the seasoned translators

garrett-eclipse commented Jun 14, 2017

I can see the performance issue there forsure, if it's about page load over server load they could be introduced through ajax if there was an endpoint to call for counts.
And maybe if not worthy of GlotPress itself the GlotDict extension could introduce for the seasoned translators

@toolstack toolstack added the has PR label Jun 23, 2017

@ocean90 ocean90 changed the title from Feature Request - Add string counts to the filter links to Add string counts to the filter links Jun 27, 2017

@ocean90 ocean90 added this to the 2.4 milestone Jun 27, 2017

@ocean90 ocean90 closed this in #741 Jun 28, 2017

@garrett-eclipse

This comment has been minimized.

Show comment
Hide comment
@garrett-eclipse

garrett-eclipse commented Jun 28, 2017

Awesome thanks @toolstack & @ocean90

@toolstack toolstack modified the milestones: 3.0, 2.4 Aug 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment