Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String containing two of the same Glossary Term doesn't highlight/underline the second one #779

Closed
garretthyder opened this issue Jul 5, 2017 · 1 comment
Assignees
Milestone

Comments

@garretthyder
Copy link

@garretthyder garretthyder commented Jul 5, 2017

Hello,

Just wanted to flag that if a string contains two of the same terms the second one doesn't get highlighted/underlined;
screen shot 2017-07-05 at 10 47 19 am
Permalink - https://translate.wordpress.org/projects/wp-plugins/wp-photo-album-plus/dev/en-ca/default?filters%5Boriginal_id%5D=4759331

Not sure if it has anything to do with the first term being a variant with suffix.

Cheers

@toolstack
Copy link
Contributor

@toolstack toolstack commented Jul 6, 2017

This is caused by the fact that we use preg_match() instead of preg_match_all() when looking for glossary terms, so only the first variant is matched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.