Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

222: Java properties support #297

Merged
merged 1 commit into from Mar 10, 2016

Conversation

Projects
None yet
3 participants
@toolstack
Copy link
Contributor

commented Feb 25, 2016

Resolves #222.

@toolstack toolstack force-pushed the 222-java-properties-support branch 2 times, most recently from 4817ef9 to c34c191 Feb 26, 2016

@toolstack toolstack changed the title 222 java properties support 222: Java properties support Feb 29, 2016

@toolstack toolstack force-pushed the 222-java-properties-support branch from fce3eb3 to e5ce7b9 Mar 3, 2016

@toolstack toolstack force-pushed the 222-java-properties-support branch from 9670b4c to 8433c16 Mar 5, 2016

@toolstack

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2016

@ocean90 I think this could be moved to 1.1, feeback would be appreciated.

$translation = $this->utf8_uni_encode( $translation );
if ( empty( $entry->context ) ) {
$original = $entry->singular;

This comment has been minimized.

Copy link
@ocean90

ocean90 Mar 6, 2016

Member

Is this really supported? It seems like the context is the key of the translation so the context must exist.

When I export a WP project I get
An\ error\ occurred\ adding\ you\ to\ this\ site.\ Back\ to\ the\ <a\ href\="%s">homepage</a>. = A ap\u0103rut o eroare la ad\u0103ugarea ta acestui sit. \u00centoarce-te la <a href="%s">prima pagin\u0103</a>.

Android skips originals without a context.

This comment has been minimized.

Copy link
@toolstack

toolstack Mar 7, 2016

Author Contributor

Yes, it supports it.

It's not very pleasant but there's nothing wrong with the exported line according to the standard, it's just not very programmer friendly to type in.

@ocean90

This comment has been minimized.

Copy link
Member

commented Mar 6, 2016

@toolstack I'm fine with 1.1, it's your call.

* @param GP_Translation_Set $translation_set The locale object the strings are being
* exported for. not used in this format but part
* of the scaffold of the parent object.
* @param GP_Translation $entries The entries to export.

This comment has been minimized.

This comment has been minimized.

Copy link
@toolstack

toolstack Mar 7, 2016

Author Contributor

That doesn't actually say they should be aligned to each other 😉

It just gives a poor example because they use the same type/variable name for both.

I'll align it 😄

@toolstack toolstack added this to the 1.1 milestone Mar 7, 2016

Added support for Java properties format.
Supports Java properties files with Latin1 encoding and escaped
unicode charaters.

Supports both = and : as field delimeters.

Includes tests cases and sample data.

@toolstack toolstack force-pushed the 222-java-properties-support branch from b62e3d5 to f7f360c Mar 7, 2016

@toolstack toolstack self-assigned this Mar 10, 2016

toolstack added a commit that referenced this pull request Mar 10, 2016

@toolstack toolstack merged commit 79ecc6b into develop Mar 10, 2016

3 checks passed

Scrutinizer 8 new issues, 14 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@toolstack toolstack deleted the 222-java-properties-support branch Mar 10, 2016

@IvanRF

This comment has been minimized.

Copy link

commented Mar 10, 2016

👍

@swissspidy swissspidy referenced this pull request Aug 18, 2016

Closed

Add JSON format #523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.