Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

328: Replace gp_sanitize_for_url() with wp's sanitize_title(). #330

Merged
merged 2 commits into from Mar 12, 2016

Conversation

Projects
None yet
2 participants
@toolstack
Copy link
Contributor

commented Mar 11, 2016

Also remove the code and tests.

Resolves #328.

Replace gp_sanitize_for_url() with wp's sanitize_title().
Also remove the code and tests.

@toolstack toolstack added this to the 1.1 milestone Mar 11, 2016

@ocean90 ocean90 self-assigned this Mar 12, 2016

ocean90 added a commit that referenced this pull request Mar 12, 2016

@ocean90 ocean90 merged commit bcaa8d8 into develop Mar 12, 2016

3 checks passed

Scrutinizer 2 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ocean90 ocean90 deleted the 328-auto-generate-project-slug-fix branch Mar 12, 2016

ocean90 added a commit that referenced this pull request Jul 7, 2016

Replace sanitize_title() with gp_sanitize_slug() which allows periods
`sanitize_title()` was used as a replacement for `gp_sanitize_for_url()` in #330. But it doesn't support periods.

`gp_sanitize_slug()` is like `sanitize_title()` and `sanitize_title_with_dashes()`, but supports periods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.