Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

342: Update schema definitions to work with WP's dbDelta() #343

Merged
merged 1 commit into from Mar 15, 2016

Conversation

Projects
None yet
2 participants
@toolstack
Copy link
Contributor

commented Mar 15, 2016

dbDelta() doesn't support backticks so remove them from the references column name.

On compond index key's, dbDelta() expects there to be no spaces between each component and the size, so remove them.

Resolves #342.

@toolstack toolstack added this to the 1.1 milestone Mar 15, 2016

@toolstack toolstack force-pushed the 342-schema-dbdelta-errors branch from b1b1597 to 0ceea55 Mar 15, 2016

Update schema definitions to work with dbDelta().
dbDelta() doesn't support backticks but the references column is a
reserved word so add a note about the SQL error that is thrown during
upgrades.

On compond index key's, dbDelta() expects there to be no spaces between each component and the size, so remove them.

@toolstack toolstack force-pushed the 342-schema-dbdelta-errors branch from 0ceea55 to 38b1f4f Mar 15, 2016

toolstack added a commit that referenced this pull request Mar 15, 2016

Merge pull request #343 from GlotPress/342-schema-dbdelta-errors
342: Update schema definitions to work with WP's dbDelta()

@toolstack toolstack merged commit 2c1cab4 into develop Mar 15, 2016

4 checks passed

Scrutinizer 2 new issues
Details
codecov/project 35.69% remains the same compared to 3efce72
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@toolstack toolstack deleted the 342-schema-dbdelta-errors branch Mar 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.