New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

388: Fix project path during upgrade #410

Merged
merged 6 commits into from Apr 25, 2016

Conversation

Projects
None yet
2 participants
@toolstack
Copy link
Contributor

toolstack commented Apr 15, 2016

Resolves #388.

@toolstack toolstack added this to the 2.0.1 milestone Apr 15, 2016

toolstack added some commits Apr 15, 2016

}
if ( $db_version < 950 ) {
$wpdb->query( "UPDATE {$wpdb->gp_projects} SET `path`=SUBSTR(`path`, 1, LENGTH(`path`) - 1) WHERE `path` LIKE '%/';" );

This comment has been minimized.

@ocean90

ocean90 Apr 19, 2016

Member

This needs to be CHAR_LENGTH() and let's use SUBSTRING(). Some whitespace before/after the equal sign would be nice too.

@@ -27,7 +27,7 @@
*/
define( 'GP_VERSION', '2.1.0-alpha' );
define( 'GP_DB_VERSION', '940' );
define( 'GP_DB_VERSION', '950' );

This comment has been minimized.

@ocean90

ocean90 Apr 19, 2016

Member

940 was a SVN revision, should we change the version to a date?

This comment has been minimized.

@toolstack

toolstack Apr 19, 2016

Contributor

I wondered where the number came from.

Either just an incrementing number (I chose ten, but any increment would do) or date.

Date is kind of ugly and does limit us to once change a day 😉.

@toolstack toolstack merged commit dbdfa7b into develop Apr 25, 2016

2 of 3 checks passed

codecov/project 34.26% (-0.01%) compared to 9ff141c at 34.27%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@toolstack toolstack deleted the 388-fix-project-path-during-upgrade branch Apr 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment