Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

688: Remove invalid 'me' language code #619

Merged
merged 1 commit into from Sep 26, 2017
Merged

Conversation

@jdevalk
Copy link
Contributor

@jdevalk jdevalk commented Dec 4, 2016

'me' is not a valid 639-1 language code, so it should not be in here. See the Wiki page for the language.

See #688.

@toolstack
Copy link
Contributor

@toolstack toolstack commented Dec 5, 2016

It does look like it has a 639-3 code though so that should be added in to replace the 639-1 code.

@jdevalk
Copy link
Contributor Author

@jdevalk jdevalk commented Dec 5, 2016

No, mis means "no code".

@ocean90 ocean90 added this to the Future milestone Dec 11, 2016
@ocean90 ocean90 modified the milestones: 2.3, Future Jan 10, 2017
@ocean90 ocean90 modified the milestones: 2.4, Future Mar 5, 2017
@ocean90 ocean90 requested a review from petyaraykovska Mar 6, 2017
@petyaraykovska
Copy link
Contributor

@petyaraykovska petyaraykovska commented Mar 6, 2017

I don't think we should remove work that is already in progress even if there is no official ISO 639-1 code for the language. In reading the Wikipedia article, Ethnologue and a couple of other sources, it looks like Montenegrin status is not defined, but constantly discussed politically.

For WordPress, the locale is done at more than 40% (https://translate.wordpress.org/locale/me/default/wp/dev) and we have been known to add locales that have not been permanently defined yet (Albanian as spoken in Kosovo).

If we can keep the locale for WordPress and remove it from GlotPress, fine. Otherwise we can not remove this locale.

me_ME comes from the location definition in ISO 3166-2:ME, the entry for Montenegro in ISO 3166-2, part of the ISO 3166 standard published by the International Organization for Standardization (ISO).

@ocean90
Copy link
Member

@ocean90 ocean90 commented Mar 15, 2017

@petyaraykovska This only about removing the ISO 639-1 code, not the entire locale.

@ocean90
Copy link
Member

@ocean90 ocean90 commented Mar 21, 2017

Instead of no ISO code I'd like to see $me->lang_code_iso_639_3 = 'mis'; being used. http://www-01.sil.org/iso639-3/documentation.asp?id=mis

Currently all locales have an ISO code and systems like the w.org API for translations might expect at least one code.

@toolstack toolstack modified the milestones: 3.0, 2.4 Aug 15, 2017
@toolstack toolstack changed the title Remove invalid 'me' language code 688: Remove invalid 'me' language code Aug 17, 2017
@ocean90 ocean90 merged commit 59c723d into GlotPress:develop Sep 26, 2017
2 checks passed
2 checks passed
codecov/project 37.27% (+<.01%) compared to 54baf30
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.