New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change string for consistency #722

Merged
merged 2 commits into from Jul 2, 2017

Conversation

Projects
None yet
3 participants
@pedro-mendonca
Contributor

pedro-mendonca commented May 26, 2017

Rename "with warnings" to comply with the filter string "Warnings"

Change string for consistency
Rename "with warnings" to comply with the filter string "Warnings"
@toolstack

This comment has been minimized.

Show comment
Hide comment
@toolstack

toolstack May 29, 2017

Contributor

I'm not sure "Warnings" is the right term here as being consistent with the other items in the legend may not be the best solution.

The other legend items are all mutually exclusive, aka you can't have "Current" and "Waiting", but you can have "Current" and "with warnings".

"with warnings" is a modifier of the other items, so while "with warnings" may not be the best, it doesn't have to be the same as the others.

Perhaps "has Warnings" or "Warnings present" or something else?

Contributor

toolstack commented May 29, 2017

I'm not sure "Warnings" is the right term here as being consistent with the other items in the legend may not be the best solution.

The other legend items are all mutually exclusive, aka you can't have "Current" and "Waiting", but you can have "Current" and "with warnings".

"with warnings" is a modifier of the other items, so while "with warnings" may not be the best, it doesn't have to be the same as the others.

Perhaps "has Warnings" or "Warnings present" or something else?

@pedro-mendonca

This comment has been minimized.

Show comment
Hide comment
@pedro-mendonca

pedro-mendonca May 29, 2017

Contributor

Comparison to other platforms:

Poedit uses With errors
Transifex uses With issues

Contributor

pedro-mendonca commented May 29, 2017

Comparison to other platforms:

Poedit uses With errors
Transifex uses With issues

@ocean90

This comment has been minimized.

Show comment
Hide comment
@ocean90

ocean90 May 30, 2017

Member

Attaching a screenshot so everyone knows what this is about:

legend

In this case it's about the label for the legend. I'd probably change it to "With warnings" (capital "W").

Member

ocean90 commented May 30, 2017

Attaching a screenshot so everyone knows what this is about:

legend

In this case it's about the label for the legend. I'd probably change it to "With warnings" (capital "W").

@ocean90

This comment has been minimized.

Show comment
Hide comment
@ocean90

ocean90 Jul 1, 2017

Member

@pedro-mendonca Do you want to update the PR to change the string to a capital "W"?

Member

ocean90 commented Jul 1, 2017

@pedro-mendonca Do you want to update the PR to change the string to a capital "W"?

@pedro-mendonca

This comment has been minimized.

Show comment
Hide comment
@pedro-mendonca

pedro-mendonca Jul 1, 2017

Contributor

@ocean90 of course -> "With Warnings"

Contributor

pedro-mendonca commented Jul 1, 2017

@ocean90 of course -> "With Warnings"

@pedro-mendonca

This comment has been minimized.

Show comment
Hide comment
Contributor

pedro-mendonca commented Jul 1, 2017

@ocean90 ocean90 added this to the 2.4 milestone Jul 2, 2017

@ocean90

ocean90 approved these changes Jul 2, 2017

@ocean90 ocean90 merged commit e59042a into GlotPress:develop Jul 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@toolstack toolstack modified the milestones: 3.0, 2.4 Aug 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment