New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

734: Add 'ing' and 'ed' to suffix list for glossary term matching. #739

Merged
merged 2 commits into from Jun 28, 2017

Conversation

Projects
None yet
2 participants
@toolstack
Contributor

toolstack commented Jun 21, 2017

Resolves #734.

@toolstack toolstack requested a review from ocean90 Jun 21, 2017

@ocean90

Looks like you forgot to commit the file with the tests 😸

@toolstack

This comment has been minimized.

Show comment
Hide comment
@toolstack

toolstack Jun 22, 2017

Contributor

Actually I didn't add them as we don't, at the moment, test anything inside the gp-templates directory including the helper functions which this is a part of (whether that the right place for it or not is a whole different question 😉).

Contributor

toolstack commented Jun 22, 2017

Actually I didn't add them as we don't, at the moment, test anything inside the gp-templates directory including the helper functions which this is a part of (whether that the right place for it or not is a whole different question 😉).

@ocean90 ocean90 merged commit cce5c57 into develop Jun 28, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ocean90 ocean90 deleted the 734-add-suffixes-to-glossary-highlight branch Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment