Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

733: Add counts to filter links in the translation page. #741

Merged
merged 3 commits into from Jun 28, 2017

Conversation

@toolstack
Copy link
Contributor

toolstack commented Jun 22, 2017

Resolves #733.

@toolstack toolstack requested a review from ocean90 Jun 22, 2017
@toolstack toolstack changed the title 237: Add counts to filter links in the translation page. 732: Add counts to filter links in the translation page. Jun 22, 2017
@toolstack toolstack changed the title 732: Add counts to filter links in the translation page. 733: Add counts to filter links in the translation page. Jun 22, 2017
@toolstack toolstack force-pushed the 733-add-counts-to-filter-links branch from 8b73a4a to 40a1142 Jun 24, 2017
Copy link
Member

ocean90 left a comment

Since we now have the counts, should we hide the links if the count is zero?

$filter_links[] = gp_link_get(
add_query_arg( $untranslated_filters, $url ),
// Translators: %d is the untranslated strings count for the current translation set.
sprintf( __( 'Untranslated [%d] (random)', 'glotpress' ), $translation_set->untranslated_count() )

This comment has been minimized.

Copy link
@ocean90

ocean90 Jun 27, 2017

Member

We should use number_format_i18n() for numbers (and %s for the placeholder).

This comment has been minimized.

Copy link
@ocean90

ocean90 Jun 27, 2017

Member

Random was a separate link.

@toolstack
Copy link
Contributor Author

toolstack commented Jun 27, 2017

I kind of like seeing the zeros, it make it clear there are no fuzzies/waiting/warnings :)

It gives you a sense of accomplishment.

@ocean90 ocean90 added this to the 2.4 milestone Jun 28, 2017
@ocean90 ocean90 merged commit 77d3ccb into develop Jun 28, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ocean90 ocean90 deleted the 733-add-counts-to-filter-links branch Jun 28, 2017
@toolstack toolstack modified the milestones: 3.0, 2.4 Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.