New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

226: support locale variants #747

Open
wants to merge 16 commits into
base: develop
from

Conversation

Projects
None yet
5 participants
@toolstack
Contributor

toolstack commented Jun 27, 2017

Resolves #226 .

@toolstack toolstack requested a review from ocean90 Jun 27, 2017

@toolstack toolstack added this to the 3.0 milestone Jun 30, 2017

Show outdated Hide outdated locales/locales.php
@@ -972,6 +1010,8 @@ public function __construct() {
$gsw->country_code = 'ch';
$gsw->wp_locale = 'gsw';
$gsw->slug = 'gsw';
$gsw->variant_root = $de->slug;

This comment has been minimized.

@swissspidy

swissspidy Jul 12, 2017

Contributor

Please note that while German (Switzerland) as a variant of standard German makes sense, Swiss German (gsw) is something completely different. It's a dialect (well, more than 26 different dialects to be precise) that has nothing in common with regular German. As such, $gsw shouldn't be a variant of $de.

@swissspidy

swissspidy Jul 12, 2017

Contributor

Please note that while German (Switzerland) as a variant of standard German makes sense, Swiss German (gsw) is something completely different. It's a dialect (well, more than 26 different dialects to be precise) that has nothing in common with regular German. As such, $gsw shouldn't be a variant of $de.

This comment has been minimized.

@pixelverbieger

pixelverbieger Jul 12, 2017

… while de_DE_formal is missing and should be added to the list of variants for German

@pixelverbieger

pixelverbieger Jul 12, 2017

… while de_DE_formal is missing and should be added to the list of variants for German

This comment has been minimized.

@swissspidy

swissspidy Jul 12, 2017

Contributor

That would be handled somewhere else though 🙂 de_DE_formal is not listed in locales.php after all, it's probably just a WordPress.org thing.

@swissspidy

swissspidy Jul 12, 2017

Contributor

That would be handled somewhere else though 🙂 de_DE_formal is not listed in locales.php after all, it's probably just a WordPress.org thing.

This comment has been minimized.

@toolstack

toolstack Jul 12, 2017

Contributor

Thanks @swissspidy, I'll remove the relationship.

@pixelverbieger I'm sure there will be many new variants added, like de_DE_formal once the the PR is merged, currently swsisspidy is correct that the formal variants are handled by translate.w.org separately.

@toolstack

toolstack Jul 12, 2017

Contributor

Thanks @swissspidy, I'll remove the relationship.

@pixelverbieger I'm sure there will be many new variants added, like de_DE_formal once the the PR is merged, currently swsisspidy is correct that the formal variants are handled by translate.w.org separately.

toolstack added a commit that referenced this pull request Jul 12, 2017

toolstack added a commit that referenced this pull request Jul 12, 2017

@GlotPress GlotPress deleted a comment from fiona0407 Aug 3, 2017

toolstack added a commit that referenced this pull request Oct 8, 2017

Show outdated Hide outdated gp-templates/translation-row.php
@@ -178,6 +178,32 @@
</dl>
-->
<?php if ( property_exists( $t, 'root_translation_set_id' ) ) : ?>
<dl>
<dt><?php _e( 'Root Translaton:', 'glotpress' ); ?></dt>

This comment has been minimized.

@ocean90

ocean90 Nov 23, 2017

Member

Typo

@ocean90

This comment has been minimized.

@toolstack

toolstack Nov 23, 2017

Contributor

Fixed.

@toolstack

toolstack Nov 23, 2017

Contributor

Fixed.

toolstack added some commits Nov 23, 2017

@HughP

This comment has been minimized.

Show comment
Hide comment
@HughP

HughP Apr 21, 2018

I’m not sure why the code invokes iso 629-2 codes. BCP 47 Tags should be used.

I don’t have a problem with the fallbacks chosen. They make sense. But it seems that the coding seems more complex than needed. ISO 639-2 and 639-3 are alligned for the purposes of locale codes CLDR or Iana should have the already Approved codes.

HughP commented Apr 21, 2018

I’m not sure why the code invokes iso 629-2 codes. BCP 47 Tags should be used.

I don’t have a problem with the fallbacks chosen. They make sense. But it seems that the coding seems more complex than needed. ISO 639-2 and 639-3 are alligned for the purposes of locale codes CLDR or Iana should have the already Approved codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment