New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

775: Set the initial hidden state for the bulk priority select with CSS #777

Merged
merged 1 commit into from Jul 3, 2017

Conversation

Projects
None yet
3 participants
@ocean90
Member

ocean90 commented Jul 2, 2017

Also, hide the priority action for no-JS.

Fixes #775.

Set the initial hidden state for the bulk priority select with CSS.
Also, hide the priority action for no-JS.

Fixes #775.

@ocean90 ocean90 added this to the 2.4 milestone Jul 2, 2017

@ocean90 ocean90 self-assigned this Jul 2, 2017

@ocean90 ocean90 requested a review from toolstack Jul 2, 2017

@toolstack toolstack changed the title from Set the initial hidden state for the bulk priority select with CSS to 775: Set the initial hidden state for the bulk priority select with CSS Jul 2, 2017

@@ -1,4 +1,7 @@
jQuery(function($) {
var $bulkActions = $( '#bulk-action' ),
$bulkPriority = $( '#bulk-priority' );

This comment has been minimized.

@toolstack

toolstack Jul 2, 2017

Contributor

Does this need a var statement in front of it?

@toolstack

toolstack Jul 2, 2017

Contributor

Does this need a var statement in front of it?

This comment has been minimized.

@swissspidy

swissspidy Jul 2, 2017

Contributor

No, because of the comma this is the same as var $bulkActions = …; var $bulkPriority = …;

@swissspidy

swissspidy Jul 2, 2017

Contributor

No, because of the comma this is the same as var $bulkActions = …; var $bulkPriority = …;

@@ -34,7 +34,7 @@
<option value="reject"><?php _e( 'Reject', 'glotpress' ); ?></option>
<option value="fuzzy"><?php _e( 'Fuzzy', 'glotpress' ); ?></option>
<?php if( $can_write ) : ?>
<option value="set-priority"><?php _e( 'Set Priority', 'glotpress' ); ?></option>
<option value="set-priority" class="hide-if-no-js"><?php _e( 'Set Priority', 'glotpress' ); ?></option>

This comment has been minimized.

@toolstack

toolstack Jul 2, 2017

Contributor

Should we hide this without JS? A non-JS user would never be able to set the bulk priority if we do. Though, I think it's safe to say that JS is a requirement for GP :)

@toolstack

toolstack Jul 2, 2017

Contributor

Should we hide this without JS? A non-JS user would never be able to set the bulk priority if we do. Though, I think it's safe to say that JS is a requirement for GP :)

This comment has been minimized.

@ocean90

ocean90 Jul 2, 2017

Member

I think it's safe to say that JS is a requirement for GP

It is. You can't submit any translations without JS because the editor isn't visible. 🙃

@ocean90

ocean90 Jul 2, 2017

Member

I think it's safe to say that JS is a requirement for GP

It is. You can't submit any translations without JS because the editor isn't visible. 🙃

@toolstack toolstack merged commit aa220c9 into develop Jul 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@toolstack toolstack deleted the 775-filter-flashing branch Jul 3, 2017

@toolstack toolstack modified the milestones: 3.0, 2.4 Aug 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment