gp_translations_imported doesn't pass imported string IDs

[iandunn]

Problem

gp_translations_imported only passes the ID of the translation set:

GlotPress/gp-includes/things/translation-set.php

Lines 366 to 373 in 3d975df

	/**
	* Fires after translations have been imported to a translation set.
	*
	* @since 1.0.0
	*
	* @param int $translation_set The ID of the translation set the import was made into.
	*/
	do_action( 'gp_translations_imported', $this->id );

I'd like my callback to know which strings were imported, so that I can add activity notifications to a BuddyPress installation.

Desired Solution

It seems like the simplest approach would be for the action to pass an array of imported translation IDs to its callbacks, similar to what gp_translation_set_bulk_action_post does.

e.g.,

$translation = GP::$translation->create( $entry );
+$created_translation_ids[] = $translation->id;

// ...

-do_action( 'gp_translations_imported', $this->id ); 
+do_action( 'gp_translations_imported', $this->id, $created_translation_ids ); 

Other solutions I considered

• Use gp_translation_created | gp_translation_saved - It's not performant to process them individually, since the processing involves an HTTP request and database write. To avoid that using these actions, I'd have to store each ID in a global/static var, and then run my logic for all of the entries once the process is done.
• Parse from $_FILES['import-file'] - That requires duplicating a lot of the logic of the import process, and still wouldn't let me know which were imported (where $create = true)

[ocean90]

• Use gp_translation_created | gp_translation_saved - It's not performant to process them individually, since the processing involves an HTTP request and database write. To avoid that using these actions, I'd have to store each ID in a global/static var, and then run my logic for all of the entries once the process is done.

That's something we already doing in several places like WPorg_GP_Project_Stats or Translation_Sync with the help of the shutdown action.

But sure, we can extend the function to track the IDs of new translations and pass them to the action.