New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityType.isSpawnable() not always suitable for SummonCommand #541

Closed
Postremus opened this Issue Aug 10, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@Postremus
Contributor

Postremus commented Aug 10, 2017

Hello,

In Vanilla, I can spawn a fireworks_rocket entity using:
/summon minecraft:fireworks_rocket ~ ~ ~ {Life:0,LifeTime:0}
Without the nbt, vanilla still spawns a firework entity, which plays some particles, and dies immediately.

In Glowstone however, this will not be possible in the summon command.
https://github.com/GlowstoneMC/Glowstone/blob/master/src/main/java/net/glowstone/command/minecraft/SummonCommand.java#L90
This line checks if the type is spawnable. For fireworks rockets, this returns false.

regards
Postremus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment