PlayerInteractEvent is never fired with Action.RIGHT_CLICK_AIR

[kaenganxt]

I tested some plugins with glowstone and realized that the PlayerInteractEvent is never fired with Action.RIGHT_CLICK_AIR.

The only place in the code where RIGHT_CLICK_AIR is used, is when the right clicked blocked does not exist, and even then the event is not fired most of the time because of the return.
There are two more problems here:

1. The clicked.getLocation() in line 118 might cause a null pointer because it is inside the clicked == null block
2. When placing a block against a non-existent block, the client places the new block successfully, but Glowstone only reverts the clicked block (line 118 again) and not the newly placed block.

I'm not completely sure where a RIGHT_CLICK_AIR should be fired, there are two cases I would consider:

1. Here's some code in a comment, which would fire a right click when the direction is -1, but I can't find documentation about this case on wiki.vg.
2. The UseItem packet, because currently there's no event fired.

[aramperes]

I fixed some of these issues in 9254c74

• The null check was impossible, because getBlockAt never returns null
• Added newly placed block reversion
• Added the right-click-air event in UseItem.

Please check with your use-cases if this solves your issues. I'm not sure about the -1 direction in the block placement packet either.

[kaenganxt]

RIGHT_CLICK_AIR now works as expected. I'm going to open a PR later to fix some other issues with the player interact event I found.