PlayerInteractEvent is never fired with Action.RIGHT_CLICK_AIR #595
Comments
aramperes
added a commit
that referenced
this issue
Dec 17, 2017
* Removed impossible null check * Revert newly placed block on client-side when perception is incorrect * Call and handle right-click-air interact event in UseItemHandler
I fixed some of these issues in 9254c74
Please check with your use-cases if this solves your issues. I'm not sure about the |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I tested some plugins with glowstone and realized that the PlayerInteractEvent is never fired with
Action.RIGHT_CLICK_AIR
.The only place in the code where
RIGHT_CLICK_AIR
is used, is when the right clicked blocked does not exist, and even then the event is not fired most of the time because of the return.There are two more problems here:
clicked.getLocation()
in line 118 might cause a null pointer because it is inside theclicked == null
blockI'm not completely sure where a
RIGHT_CLICK_AIR
should be fired, there are two cases I would consider:The text was updated successfully, but these errors were encountered: