Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Event Coverage #922

Open
aramperes opened this issue May 24, 2018 · 8 comments
Open

API Event Coverage #922

aramperes opened this issue May 24, 2018 · 8 comments

Comments

@aramperes
Copy link
Member

@aramperes aramperes commented May 24, 2018

Disclaimer for new contributors

Glowstone is an open-source project under the MIT license. In addition, we have a Contributors License Agreement which includes restrictions on the source of contributions (e.g. decompiled code from Mojang, Spigot, etc.). You will be asked to sign the CLA when submitting your first Pull Request.

Task

As suggested by creatorfromhell, this is a to-do list of API events that are not partially or fully implemented in Glowstone, including a direct link to their documentation.

Events are an important aspect of our coverage of the Bukkit, Spigot, and Paper APIs.

In bold are events whose feature is implemented, but missing the event firing.

Block Events

Command Events

Nothing here

Enchantment Events

Nothing here

Entity Events

Hanging Entity Events

Nothing here

Inventory Events

Player Events

Profile Events

Server Events

Vehicle Events

Weather Events

Nothing here

World Events


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@aramperes aramperes changed the title Unimplemented Events API Event Coverage May 25, 2018
aramperes added a commit that referenced this issue May 27, 2018
aramperes added a commit that referenced this issue Jun 1, 2018
Related to #922.
aramperes added a commit that referenced this issue Jun 1, 2018
Related to #922.
aramperes added a commit that referenced this issue Jun 2, 2018
Related to #922.
aramperes added a commit that referenced this issue Jun 2, 2018
Related to #922.
aramperes added a commit that referenced this issue Jun 3, 2018
Related to #922.
aramperes added a commit that referenced this issue Jun 3, 2018
Related to #922.

* Fixed /whitelist remove <player> showing usage error even on success
mastercoms added a commit that referenced this issue Jun 5, 2018
mastercoms added a commit that referenced this issue Jun 7, 2018
@VaiTon
Copy link
Contributor

@VaiTon VaiTon commented Dec 16, 2018

EntityShootBowEvent is implemented here

VaiTon added a commit to VaiTon/Glowstone that referenced this issue Dec 17, 2018
VaiTon added a commit to VaiTon/Glowstone that referenced this issue Dec 17, 2018
VaiTon added a commit to VaiTon/Glowstone that referenced this issue Dec 17, 2018
VaiTon added a commit to VaiTon/Glowstone that referenced this issue Dec 17, 2018
@heisluft
Copy link
Contributor

@heisluft heisluft commented Jan 31, 2019

I implemented PlayerLocaleChangeEvent in #1011

Pr0methean added a commit that referenced this issue Feb 3, 2019
* Implement BlockPistonExtendEvent firing (addresses #922)

* Fix code style
@aramperes
Copy link
Member Author

@aramperes aramperes commented Feb 4, 2019

@VaiTon I see that a few commits in your fork mentioned this issue. Do you plan on PR-ing these changes?

@jhg023
Copy link
Contributor

@jhg023 jhg023 commented Feb 9, 2019

All of the links to the respective event documentation seem to be dead 👻

@SHADOWDANCH
Copy link
Contributor

@SHADOWDANCH SHADOWDANCH commented Jul 19, 2019

BlockPistonRetractEvent is firing here
BroadcastMessageEvent is firing here
ProjectileHitEvent is firing here
PlayerExpChangeEvent is firing here
VehicleCreateEvent is firing here

@SHADOWDANCH
Copy link
Contributor

@SHADOWDANCH SHADOWDANCH commented Jul 21, 2019

BlockPhysicsEvent is firing here

@aramperes
Copy link
Member Author

@aramperes aramperes commented Jul 24, 2019

I updated the links to use the Paper 1.12 docs, so they should no longer be dead.

mastercoms added a commit that referenced this issue Aug 5, 2019

* No longer fire PlayerInitialSpawnEvent in GlowPlayer

It will be fired in player-specific code in GlowEntity, instead.

* Fire PlayerInitialSpawnEvent in GlowEntity

This way, it is ordered correctly with other event calls.

* Fix setting events' world not affecting player
@JoelLau
Copy link

@JoelLau JoelLau commented Oct 9, 2019

I'm decent at Java, admire minecraft (have the game), but don't play much. Would anybody be willing to give me guide me as I make my first pull requests here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants