Skip to content

i18nize /deop and /difficulty; extract out LocalizedEnumNames #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 31, 2018

Conversation

Pr0methean
Copy link
Contributor

Most of the functionality of GameModeUtils is now in LocalizedEnumNames, generified for classes other than GameMode, and now also used with Difficulty.

Also extracts out the LocalizedEnumNames class, which is now used for both game modes and difficulties.
Copy link
Member

@mastercoms mastercoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mastercoms mastercoms merged commit e856bd3 into dev Dec 31, 2018
@mastercoms mastercoms deleted the i18n201901.01 branch February 3, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants