Merged
Conversation
mastercoms
previously requested changes
Jan 6, 2019
Member
mastercoms
left a comment
mastercoms
left a comment
There was a problem hiding this comment.
Hey, we discussed the namespaces a bit in the Discord, and I think an easy fix for now would be to check if a colon exists in the string before adding the Minecraft prefix. Also, please use Namespacedkey.MINECRAFT.
mastercoms
approved these changes
Jan 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Localizes commands E through O. Also properly logs when /op or /deop fails with an exception, with a localized message, replacing
ex.printStackTrace().Once this is merged, 20 of all 49 commands will have been i18nized, up from 8.
Also deploys the utility method
CommandUtils.toNamespacedto append theminecraft:prefix when no namespace prefix is present, but make no change when an explicit namespace is present. This probably creates better error messages if a command is unsupported by Glowstone.