Animal feeding improvements #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implements horse healing. * Implements growing. * Food no longer consumed if !canBreed() && !canGrow() (except by horses, who are healed by food).
|
What kind of live testing is required for this? Could you describe some testing steps? |
|
Test that:
|
|
I tried your test and actually noticed some stuff:
The other things seem to work, I will also try to take a look soon to improve animal feeding |
|
@FlorentClarret For your test where food was falsely consumed, would the cow and pig have been expected to enter Love Mode? If not, why not? |
|
I just gave wheat to a cow, which was not in love mode and the cow entered in love mode as expected, but after that the wheat is still consumed if I keep giving it wheat. I tried on vanilla an it's not the case, the wheat is not consumed if the cow is already in love mode. |
- Heart particles should now spawn above the mob's head. - Food won't be consumed to refresh love mode if already active.
|
Both issues should be fixed now. |
FlorentClarret
approved these changes
Apr 29, 2019
aramperes
previously requested changes
Apr 29, 2019
src/main/java/net/glowstone/entity/passive/GlowAbstractHorse.java
Outdated
Show resolved
Hide resolved
aramperes
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GlowAbstractHorse.canBreed()can no longer return true if untamed.