i18nize and refactor GlowstoneCommand #1026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramperes
previously requested changes
Mar 1, 2019
| // thread count | ||
| int threadCount = 0; | ||
| Set<Thread> threads = Thread.getAllStackTraces().keySet(); | ||
| for (Thread thread : threads) { |
There was a problem hiding this comment.
Could you refactor this to use a Stream?
| new LocalizedStringImpl("glowstone.about", b).send(sender); | ||
| LocalizedStringImpl t | ||
| = new LocalizedStringImpl("glowstone.about._template", b); | ||
| sendBullet(sender, t, b, "glowstone.about.brand", Bukkit.getName()); |
There was a problem hiding this comment.
Could you rename the b and t variables to be more descriptive?
There was a problem hiding this comment.
I'll look into how much longer they can be while still fitting most of the sendBullet calls on one line each.
| case PROPERTY: | ||
| return StringUtil | ||
| .copyPartialMatches(args[1], | ||
| System.getProperties().stringPropertyNames(), |
There was a problem hiding this comment.
What's going on here with all the whitespace? It's hardly readable 😛
aramperes
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subcommands are now looked up through an ImmutableSortedMap that ensures English case folding.