Only run delombok in ci #1068
Merged
Only run delombok in ci #1068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source files by delombok are only required for javadoc. We now hide delombok, javadoc jar, and source jar generation behind profile build-extras. The profile can be activated on locally as well. This should make it easier to debug ci problems.
gdude2002
pushed a commit
that referenced
this pull request
Jan 23, 2020
The source files by delombok are only required for javadoc. We now hide delombok, javadoc jar, and source jar generation behind profile build-extras. The profile can be activated on locally as well. This should make it easier to debug ci problems.
mastercoms
pushed a commit
that referenced
this pull request
Jan 24, 2020
The source files by delombok are only required for javadoc. We now hide delombok, javadoc jar, and source jar generation behind profile build-extras. The profile can be activated on locally as well. This should make it easier to debug ci problems.
mastercoms
added a commit
that referenced
this pull request
Aug 5, 2020
This reverts commit c2c5a2e. # Conflicts: # pom.xml
mastercoms
added a commit
that referenced
this pull request
Aug 7, 2020
This reverts commit d115d69.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source files by delombok are only required for javadoc.
We now hide delombok, javadoc jar, and source jar generation behind profile build-extras.
The profile can be activated on locally as well. This should make it easier to debug ci problems.
These changes have a positiv impact on local build time.
In my tests, I built the project using
mvn package -DskipTests.Before my changes, this took around 45 seconds.
After my changes, this takes around 32 seconds.