Fix wrong coordinates in isSnowy #1075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastercoms
approved these changes
Jan 17, 2020
|
Thank you for your contribution to Glowstone! |
gdude2002
pushed a commit
that referenced
this pull request
Jan 23, 2020
mastercoms
pushed a commit
that referenced
this pull request
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values of x and z variables over here are absolute world coordinates (the coordinates aren't relative to the chunk). Adding sourceX and sourceZ (the absolute coordinates of the chunk's beginning) sets the value far too high.
Possibly, the author was trying to do something like this: https://github.com/GlowstoneMC/Glowstone/blob/dev/src/main/java/net/glowstone/generator/objects/Lake.java#L95
But in Lake.java, x and z are coordinates relative to the chunk so it makes sense in Lake.