Skip to content

Fix checkstyle violations #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Conversation

plexus
Copy link
Contributor

@plexus plexus commented Feb 4, 2020

So the build is no longer red.

@claassistantio
Copy link

claassistantio commented Feb 4, 2020

CLA assistant check
All committers have signed the CLA.

@mastercoms
Copy link
Member

The checkstyle rules should be upgraded instead, so that this code which conforms to our style passes checkstyle.

Copy link
Member

@mastercoms mastercoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I investigated further and fixed the brace rule. However, the import spacing rule is apparently intended, since the checkstyle was intended to enforce no spaces between groups. I guess we will have to roll with it for now, as any changes to the import order rules is going to cause much more breakage (1000 files) instead of this relatively small fix.

So, could you please revert the brace changes, and then I'll merge the import changes. Thanks for contributing!

@plexus
Copy link
Contributor Author

plexus commented Feb 6, 2020

I undid the brace changes and rebased. Thanks!

@mastercoms
Copy link
Member

Thank you for your contribution to Glowstone!

@mastercoms mastercoms merged commit b1a1b5a into GlowstoneMC:dev Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants