Fix potion effects display to self

[SHADOWDANCH]

As players now have real entity id for self intead 0 (c1fa660) there is no need for separated packet with entity id 0. Also implement LivingEntity#getPotionEffect(PotionEffectType)

[aramperes]

Could you link some documentation that the entity ID changed? Was this done in 1.12 or later versions?

[SHADOWDANCH]

Could you link some documentation that the entity ID changed? Was this done in 1.12 or later versions?

Sorry for my poor english. Entity id not changed in minecraft. Before this commit c1fa660 in glowstone all players have entity id 0 for self at clientside. And after it players at clientside have real entity id like it on original minecraft server. And so after this commit there is no need for sending separated packet with 0 entity id

[aramperes]

The client expects/expected an ID of 0 to refer to itself. This may have changed, but it would be good to know in which version this changed.

[SHADOWDANCH]

The client expects/expected an ID of 0 to refer to itself. This may have changed, but it would be good to know in which version this changed.

I am not sure in what version this changed. But 1.12.2 client not uses 0 id for self. It receives self id from server in SPacketJoinGame

[aramperes]

I asked on IRC and you are right, it is preferable to use the real entity ID. Historically, ID 0 worked because from the client's perspective, its own character is the first entity in the worls (so 0 index).