Skip to content

Add background option to GlowAdvancementDisplay. Fix client crash #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2020
Merged

Add background option to GlowAdvancementDisplay. Fix client crash #1093

merged 1 commit into from
May 6, 2020

Conversation

SHADOWDANCH
Copy link
Contributor

If using 1.12.2 (without forge) client will crash on advancements gui open when on glowstone server. It's related to test advancement and the fact that it doesn't have background set in AdvacementsDisplay.
Here the stacktrace of client crash:

java.lang.NullPointerException: Registering texture
    at cdt.a(SourceFile:215)
    at cdm.a(SourceFile:46)
    at cdr.a(SourceFile:60)
    at cdr.a(SourceFile:42)
    at blx.f(SourceFile:96)
    at bmb.c(SourceFile:138)
    at bmb.a(SourceFile:118)
    at buq.a(SourceFile:1079)
    at bib.az(SourceFile:1023)
    at bib.a(SourceFile:419)
    at net.minecraft.client.main.Main.main(SourceFile:123)

@mastercoms mastercoms merged commit 3c14954 into GlowstoneMC:dev May 6, 2020
@mastercoms
Copy link
Member

Thank you for your contribution to Glowstone!

@SHADOWDANCH SHADOWDANCH deleted the fix_advancements_crash branch May 7, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants