Skip to content

Adds missing cauldron-item interactions. #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 25, 2020
Merged

Adds missing cauldron-item interactions. #1097

merged 3 commits into from
May 25, 2020

Conversation

emreozcan
Copy link
Contributor

This PR adds the missing cauldron-item interactions listed in issue #1095:

  • Cauldron – Empty bucket
  • Cauldron – Water bottle

@CLAassistant
Copy link

CLAassistant commented May 8, 2020

CLA assistant check
All committers have signed the CLA.

@emreozcan emreozcan marked this pull request as ready for review May 8, 2020 17:47
@emreozcan emreozcan requested a review from mastercoms May 24, 2020 18:06
Check if the player is holding a potion instead of a water bottle inside `emptyBottle`.
getType() only needs to be called once this way.
@emreozcan
Copy link
Contributor Author

The failed check is caused by a file transfer/connectivity issue on Azure's end. Obviously I don't have access to retrying failed jobs but I hope someone who does can verify this isn't an issue with the PR.

@emreozcan emreozcan requested a review from mastercoms May 25, 2020 17:58
@mastercoms mastercoms merged commit 322b7de into GlowstoneMC:dev May 25, 2020
@emreozcan emreozcan deleted the cauldron-interactions branch May 28, 2020 22:18
@emreozcan emreozcan restored the cauldron-interactions branch May 28, 2020 22:18
@emreozcan emreozcan deleted the cauldron-interactions branch May 28, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants