Skip to content

Update EntityEffectMessage. Optimize PotionEffect's pulsing #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2020
Merged

Update EntityEffectMessage. Optimize PotionEffect's pulsing #1098

merged 2 commits into from
May 25, 2020

Conversation

SHADOWDANCH
Copy link
Contributor

@SHADOWDANCH SHADOWDANCH commented May 8, 2020 •
edited
Loading

Changes in this PR:

  • Updated EntityEffectMessage according to 1.12.2 protocol specification from wiki.vg
  • Removed updating of potion effects to clients every pulse. Duration of potion effect autimatically decreases on client. Server need to only remove it when duration time is out
  • Added updating of MetadataIndex.POTION_COLOR and MetadataIndex.POTION_AMBIENT metadata values on potion effect added/removed
  • Improvements to EffectCommand

@mastercoms mastercoms merged commit 365a74b into GlowstoneMC:dev May 25, 2020
@SHADOWDANCH SHADOWDANCH deleted the update_potion_effects branch May 25, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercoms mastercoms mastercoms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SHADOWDANCH @mastercoms