-
Notifications
You must be signed in to change notification settings - Fork 277
Add GlowAdvancementDisplay flags #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TODO here wasn't just to name the flags, but to have a way to pass them when creating the message.
I think this could be 3 new boolean fields: hasBackgroundTexture
, showToast
, hidden
which then get encoded as byte flags.
@aramperes Thank You for clarifying, I have implemented this in 6ddaaad. I think there are probably some issues with the achievement display writing (specifically the icon slot field doesn't seem to be written correctly), but I will leave these for now since you said the dev branch is not really active. |
Checkstyle does not like my empty description for the |
From Minecraft Wiki:
|
@aramperes Thanks! Implemented in 5ec1a5a |
Just implementing a TODO, added flag definitions for the AdvancementDisplay packet writing using wiki.vg.