Conversation
Contributor
Author
|
Should be good to go now, only potential thing to look at in the future is support for vines being on top/bottom of blocks, this seems to have some sort of weird support in the vanilla edition that maybe should be replicated. |
aramperes
approved these changes
Feb 6, 2021
Member
aramperes
left a comment
aramperes
left a comment
There was a problem hiding this comment.
Code looks good, however I'm not sure if this will be merged because there is a soft code-freeze on dev until we can merge the 1.16 branch.
The patch is fairly small so I'm personally not opposed to merging now. cc. @mastercoms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds physics to vines.
This means that every time a block updates near a vine the vine will break if it is not below another vine and is not currently on a solid block.
Previously placing a vine on a block, then destroying the block would result in a floating vine. Same for hanging a vine off another vine and destroying the parent vine.